Many assumptions being made in the comments; w/o quoting I'll go on paraphrases; I hope that's OK (this is my first post). For example: someone needs to die to make room (that doesn't happen now so why in the future?); most would choose this kind of immortality ("most" right now don't know or don't practice, say, the most healthy things in life, or the most efficient, etc.; I for one wouldn't choose an imortality w/o physical sensations or emotional reactions, say, to a beautiful sunset/moonrise/bird/butterfly, etc.); less farming would be better for the planet (what about all the industrial activity to produce & maintain all those "robot bodies," not to mention the power sources.
If anything, I'd be betting this "immortality biz" will have a narrow niche market, catering (SHOCKER) to the uber rich. Sad because the only real hope society has is to shake off that ruling elite that's borrowed/spent/and wheeled & dealed us onto the edge of the economic precipice we currently find ourselves perched on.